[MPlayer-dev-eng] [PATCH] -- FreeBSD RTC Support

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Dec 18 10:26:54 CET 2004


Hi,
> Hi, This patch enables RTC support for FreeBSD.
> I've personally been using rtc with mplayer for almost a year and
> it works really well and this has been an option in FreeBSD ports for 
> over 9 months now.

First question: why do you test for RTCIO_PIE_ON and not similar to the
linux test for RTCIO_IRQP_READ?
Also I'd prefer this patch to be more generic, meaning: leave the checks
for freebsd out and just check if instead of RTC_* the RTCIO_* variants
are defined.
In that case I'd also prefer if you'd add
#define RTC_IRQP_SET RTCIO_IRQP_SET
#define RTC_PIE_ON RTCIO_PIE_ON
to config.h instead of adding more #ifdefs to mplayer.c.
Or is there a name collission that would make this impossible?

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list