[MPlayer-dev-eng] [PATCH] improved AIFF PCM Audio support - take 5

[Reimar Döffinger]

Hi,
> Thank you for the clarification. Attached is the revised patch which
> eliminates the backward-seek. Please review and accept. Thank you

Sorry, got a bit lost in all those pending patches and other problems.
Our current rule is that all functions and global variables must be commented with
doxygen-comatible comments (you should make the comments at the top of
the file in that style too I'd say). See
DOCS/tech/code-documentation.txt for a short explanation of how this
works.

[...]
> +    printf("---------------------------------------\n");
> +    printf("FORM id %c%c%c%c\n", f->fId[0], f->fId[1], f->fId[2], f->fId[3]);
> +    printf("FORM size : %d\n",f->fSize);
[...]

better use mp_msg or at least print it to stderr I'd say...

> +    if(sh->ah) free(sh->ah);

> +  // aiff codec parameters:
> +  AIFF_HEADER *ah;
>    // codec-specific:
>    void* context; // codec-specific stuff (usually HANDLE or struct pointer)
>    unsigned char* codecdata; // extra header data passed from demuxer to codec

Please use the codecdata and codecdata_len instead of adding something
new.

Greetings,
Reimar Döffinger