[MPlayer-dev-eng] [PATCH] seekbar support for mp4 files

[Reimar =?UTF8?Q?D=F6ffinger?=]

Hi,
> >New patch policy says that all functions have to be documented with
> >doxygen-compatible comments. Please add that for the two functions
> >you've added.
> > 
> I added a doxygen-style header for demux_mov_info, but I don't know the 
> exact interface of demux_mov_control so I can't decently comment it.
> 
> >Please make sure that you never do a division by zero. 
> >
> I added a couple of checks, thanks.
> 
> >Your patch has leading whitespace on some lines. Please remove those
> >whitespaces.
> >
> Done too. I hope my identation is close enough of the original one 
> (which is quite different from file to file, by the way :-))

YOu should not set movi_start and especially movi_end if you don't know the values, as far as I know MPlayer might stop playing when it gets beyond
movi_end. Instead to OSD should be fixed to use demuxer_get_percent_pos instead of these values I think.

Greetings,
Reimar Döffinger