[MPlayer-dev-eng] [PATCH] Paths for x86_64

[Reimar Döffinger]

Hi,
> >>This will break systems which don't use lib64 for x86_64, at least
> >>NetBSD.
> >>IMHO you need to do at least some tests to see if that directory
> >>exists at all and then some compiler test to see if you can use
> >>it.
> I did not know that.
> >
> >I thought this looked fishy all along.  Patch rejected.
> >
> I can not see how this is worse than hardcoding $(prefix)/lib
> everywhere. Would a patch providing a `check_lib64' and a
> `use_lib64' shell function in configure get a better chance ?

I'd say only change the config.mak creation in the configure - if you
have the libs in non-standard paths (which lib64 IMHO is) it's not asked
too much if you have to specify it on the configure line.
And adding -fPIC by default absolutely is not acceptable, especially as
this is completely unrelated to the rest of the patch.
The changes to the Makefiles are probably a good idea, but you will have
to send them to the ffmpeg devel list (except the libdha one), as they belong to
libavcodec.

Greetings,
Reimar Döffinger