[MPlayer-dev-eng] Re: [PATCH] musepack support

[D Richard Felker III]

On Tue, Dec 28, 2004 at 11:49:55PM +0100, ChristianHJW wrote:
> D Richard Felker III schrieb:
> >On Fri, Dec 17, 2004 at 11:48:54PM +0100, Reza Jelveh wrote:
> >>hi,
> >>here's the musepack support patch. ive done both demuxing and decoding 
> >>at demux layer because the musepack arch doesnt allow anything else. 
> >
> >imo this is unacceptable. modify the mpc source to separate these, or
> >else put it all at the codec layer and treat it as a 'raw' audio
> >format... rich
> 
> Dont forget that current musepack Stream Version ( SV7 ) is made this 
> way that single blocks can contain parts of samples from other blocks, 
> so its impossible to clearly separate framing and frames. This made it 
> impossible for the matroska team to add clean support for MPC in MKV 
> container ( think of editing ), so we never did that.

mp3 is exactly the same, and it's no problem. it just causes minor
blips after seeking, but they quickly go away.

> Frank Klemm, the last MPC dev, had plans to do a SV 7.5 version with 
> clear frame boundaries, but he actually never started working on it.
> 
> If you need any kind of help with this, ping me so i can bring you in 
> contact with the right people.

i don't expect we will, but thanks for the offer.

rich