[MPlayer-dev-eng] Re: [PATCH] Donald Graft's kerndeint adaptive deinterlacing filter

[Diego Biurrun]

D Richard Felker III writes:
 > On Sun, Feb 01, 2004 at 05:17:49PM -0300, Diego Biurrun wrote:
 > >  > +Paint pixels which exceed the threshold white (default 0).
 > >  > +.IPs order (0 or 1)
 > >  > +Swap fields if 1 (default 0).
 > > 
 > > Hmm, why does a flag get a value?  The other filters do it by name,
 > > i.e.
 > > 
 > >   -vf kerndeint=order
 > > 
 > > instead of
 > > 
 > >   -vf kerndeint=1
 > > 
 > > IMHO this is easier to use and it is also more consistent with the
 > > rest of the filters.
 > 
 > Huh? There is no filter that works like this!

Well, hmm, yes, you are right, of course.  Dunno what I was thinking,
just ignore this comment.

 > > Since your filter does not support things like -vf kerndeint=help or
 > 
 > WTF? This is not allowed! Filters are not supposed to print help &
 > exit. G2 will have a proper way for filters to export help text.

It's called the new config layer (or so I believe):


akira:/usr/src/mplayer/dev$ ./mplayer -vf scale=help
MPlayer dev-CVS-031215-21:24-3.3.2 (C) 2000-2004 MPlayer Team

CPU: Intel Pentium MMX P55C (new) 233.8 MHz (Family: 5, Stepping: 1)
Detected cache-line size is 32 bytes
CPUflags:  MMX: 1 MMX2: 0 3DNow: 0 3DNow2: 0 SSE: 0 SSE2: 0
Compiled for x86 CPU with extensions: MMX

Reading config file /usr/local/etc/mplayer/mplayer.conf: No such file or directory
Reading config file /home/diego/.mplayer/config

 Name                 Type            Min        Max

 w                    Integer         -3         No        
 h                    Integer         -3         No        
 interlaced           Integer         0          1         
 chr-drop             Integer         0          3         
 param                Integer         0          100       
 presize              Object presets  No         No        


At least some filters do indeed print a help message and exit when
called this way.

Diego