[MPlayer-dev-eng] Re: [PATCH] enable -ss option on wmv streams

[Karl Bielefeldt]

> > > This patch enables the -ss option to cause a wmv stream to start at
> > > the specified position instead of at the beginning when the stream is
> > > first being opened.  I used snort to reverse engineer the solution and
> > > I'm not sure that I solved it the best way, but it does work well for
> > > my online classes.  As far as I can tell, there is no way to seek
> > > after the stream has been already opened, so this works differently
> > > than most seeking code I have seen in mplayer.  I welcome any
> > > feedback.
> > Someone familiar with that code?
> 
> Not that much but it seems ok. I'm wondering why the stream_time
> variable is not a simple local inside the func. Also seek_to_sec is
> a string option, so it must be freed otherwise that leak some mem.

Thanks for the feedback.  I had put the stream_time variable there
during one of my initial debug versions and forgot to put it back for
clean-up.  I have fixed that and freed the seek_to_sec variable in the
attached revised patch.  I also did a cvs update to get a more recent
baseline.  Please let me know if you have more comments.  Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wmv_ss_patch-r2
Type: text/x-patch
Size: 2828 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040203/e1b6469b/attachment.bin>