[MPlayer-dev-eng] [PATCH] Display framedropping state in the OSD

[D Richard Felker III]

On Sun, Feb 08, 2004 at 06:35:18PM -0300, Diego Biurrun wrote:
> D Richard Felker III writes:
>  > On Thu, Feb 05, 2004 at 11:21:14PM -0300, Diego Biurrun wrote:
>  > > I noticed that the "d" key toggles frame dropping, but gives no visual
>  > > feedback on the OSD, unlike similar keys that toggle, e.g. subtitle
>  > > visibility and similar stuff.  The attached patch fixes this and
>  > > displays
>  > > 
>  > >   Framedropping: [on|hard|off]
>  > > 
>  > > on the OSD depending on whether framedrop, hardframedrop or no
>  > > framedrop is currently enabled.
>  > 
>  > ROTFL!!! WTF do you think happens if the video is already playing too
>  > slow, and the user hits "d" to turn on framedrop and all the sudden
>  > osd appears? :) Yep, you guessed it! It gets even slower!
> 
> I don't think that OSD displaying has a measurable impact on
> performance if you are running close to or at 100% processor load.
> But this is just my uneducated guess.

Very uneducated. :) Subtitles on/off makes all the difference in the
world for me in certain scenes, due to the fact that alpha blending is
done in slow video ram. This will be fixed in g2, but it's a stupid
design flaw in g1 right now and there's no easy way around it. And
even in g2 it will be difficult to handle correctly with B frames...
(B frames absolutely SUCK!!!!)

Rich