[MPlayer-dev-eng] [PATCH] Fix for vo_gl2 fullscreen mode

[Attila Kinali]

On Thu, 26 Feb 2004 17:26:56 +0100
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> >>-
> >>-	XSelectInput(mDisplay, vo_window, NoEventMask);

> > Dunno...Looks wrong to me
> What part? and how it is now or the way it was before?

The XSelectInput, if it's set here to NoEventMask then it
must (and most probably is) been reset to the right values later.
If this is to prevent a race condition, for an event
which was in the mask set before and isn't in the
mask that will be set, then this is wrong anyways.
(the race condition may happend, although it's less likely)


> >>    }
> >>    else {
> >>    	vo_x11_sizehint( hint.x, hint.y, hint.width, hint.height,0 );
> >>-   	if ( !(flags&1) ) XMoveResizeWindow( mDisplay,vo_window,hint.x,hint.y,hint.width,hint.height );
> >>+   	XMoveResizeWindow( mDisplay,vo_window,hint.x,hint.y,hint.width,hint.height );
> > Why do you removed the "if" here ?
> 
> because that &1 was so ugly ;-). No seriously, without that "if" we have 
> in all cases a nice non-fullscreen window with the correct dimensions 
> for non-fs playing - one special case less that gives trouble (we 
> couldn't call vo_x11_fullscreen if we have a fullscreen window and want 
> fullscreen. But without that call, the correct window dimensions for 
> windowed playing aren't stored - giving an incorrectly sized window 
> after switching to windowed mode via 'f')

Ok
  
> > Otherwise it looks ok.
> Too bad that I still have to make sure it actually _is_ OK ;-)

It was your choice to become the maintainer ;)

		Attila Kinali

-- 
egp ist vergleichbar mit einem ikea bausatz fuer flugzeugtraeger
			-- reeler in +kaosu