[MPlayer-dev-eng] Re: [PATCH] Seek in http-streams

[Valentine Zaretsky]

Hi, Albeu!

Alban Bedel wrote:

>>Ok, maybe in this case it would be better not to use streaming_ctrl_t 
>>callback at all?
>>Using seek callback of stream_t  after checking flags of stream in 
>>stream_seek_long seems to be cleaner than my patch and your dup2
>>suggestion. What do you think of it?
>>    
>>
>
>The problem is that all this code is quiet old now. When it was originaly
>writen stream didn't used callback. So Bertrand used callbacks for the
>network drivers. But nowaday we have this double callback, that doesn't
>much sense.
>Getting rid of the callback in streaming_ctl and using the "native" stream
>callbacks seems like a good idea to me. But then you then have to modify
>all other network drivers.
>  
>
Well... I've rewritten my patch using stream seek instead of 
streaming_ctrl one -- seems to be smaller and cleaner :)
Is it acceptable now?

--
Best regards, Valentine


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: http-patch2
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040111/c10ee3ff/attachment.txt>