[MPlayer-dev-eng] [PATCH] ppc jumbo patch
Diego Biurrun
diego at biurrun.de
Mon Jan 19 21:29:16 CET 2004
Romain Dolbeau writes:
> Diego Biurrun wrote:
> > Romain Dolbeau writes:
> > > 2) liba52 patch, with AltiVec resampler
> > >
> > > --- liba52/Makefile 11 Aug 2003 20:52:50 -0000 1.9
> > > +++ liba52/Makefile 19 Jan 2004 09:31:13 -0000
> > > @@ -19,7 +19,7 @@
> > > $(AR) r $(LIBNAME) $(OBJS)
> > >
> > > test: $(LIBNAME) test.c
> > > - $(CC) $(CFLAGS) test.c ../cpudetect.c -o test ./liba52.a -lm
> > > + $(CC) $(CFLAGS) test.c ../cpudetect.c ../mp_msg.c -o test ./liba52.a -lm
> >
> > Doesn't this add an MPlayer dependency to an external library? I
> > thought mp_msg should not be used in external libs to avoid making
> > backporting unnecessarily hard.
>
> cpudetect.c use mp_msg(), so it doesn't link without
> mp_msg.c . The liba52 in ffmpeg doesn't include
> the Makefile or test.c .
I suppose it is OK then. In any case, Alex did not complain.
Diego
More information about the MPlayer-dev-eng
mailing list