[MPlayer-dev-eng] Re: [PATCH] 422p rawvideo in plus rawuyvy out

[John Earl]

On Fri, 2004-01-30 at 14:45, John Earl wrote:
> On Thu, 2004-01-29 at 16:50, D Richard Felker III wrote:
> > On Thu, Jan 29, 2004 at 11:54:14AM +0100, Attila Kinali wrote:
> > > On Wed, 21 Jan 2004 12:00:43 +0000
> > > John Earl <jwe21 at cam.ac.uk> wrote:
> > > 
> > > > > Then please, add more format. We are not going to do 2000 little commits.
> > > > > Take the code in mp_image.h dump the size calculation for ALL know
> > > > > formats and send one patch, once. I'm not willing to review each colorspace
> > > > > addition to rawvideo one by one.
> > > > 
> > > > Done (mplayer-rawvideo, attached).
> > > > 
> > > > Am re-attaching the rawuyvy output patch (useful since there isn't yet
> > > > any 4:2:2 colorspace raw output available).
> > > 
> > > Any comments on this patch ?
> > 
> > Yes, it's nonsense. We don't need 20 different "raw*" ovc's. Instead
> > make one ve_raw that supports any format...
> 
> As requested.
> 
> mplayer-raw-out.patch : removes the 'rawyuv' ovc and replaces it with a
> new 'raw' ovc which has associated commandline option -rawopts with
> parameter fourcc to specify what format to output [...]

Here's a simpler version of ve_raw without the unnecessary -rawopts (use
vf_format instead). Now supports all raw formats that vf_format
supports. Removes ve_rawyuv and ve_rawrgb as well, since I can't see it
used anywhere else.

Hopefully not nonsense anymore. Comments?

John
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-raw-out3.patch
Type: text/x-patch
Size: 13898 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040131/1ac927c5/attachment.bin>