[MPlayer-dev-eng] [PATCH] OS/X vo_gl2.c compile error

[Ivan Kalvachev]

I donno anything about OpenGL, but I would like to assert you about
the #ifdef clause!

             !!
 #ifdef TEXTUREFORMAT_ALWAYS
-  gl_internal_format=TEXTUREFORMAT_ALWAYS;
-  gl_internal_format_s=TEXTUREFORMAT_ALWAYS_S;
+  gl_internal_format=TEXTURE_FORMAT_ALWAYS;
+  gl_internal_format_s=TEXTURE_FORMAT_ALWAYS_S;
 #endif

i guess that:

-#ifdef TEXTUREFORMAT_ALWAYS
+#if defined(TEXTUREFORMAT_ALWAY) && defined(TEXTUREFORMAT_ALWAYS_S)
   gl_internal_format=TEXTUREFORMAT_ALWAYS;
   gl_internal_format_s=TEXTUREFORMAT_ALWAYS_S;
 #endif
+
+#if defined(TEXTURE_FORMAT_ALWAY) && defined(TEXTURE_FORMAT_ALWAYS_S)
+  gl_internal_format=TEXTURE_FORMAT_ALWAYS;
+  gl_internal_format_s=TEXTURE_FORMAT_ALWAYS_S;
+#endif

would do a better job (this is hand writen patch!!!)


Wish You Best
   Ivan Kalvachev
  iive


Steven M. Schultz said:
> Hi -
>
> cc -c -I../libvo -I../../libvo -I/usr/X11R6/include -O4 -mcpu=7450 -mtune=7450
> -faltivec -pipe -ffast-math -fomit-frame-pointer -DSYS_DARWIN -DCONFIG_DARWIN
> -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64  -I. -I.. -I../osdep
> -I/usr/X11R6/include -I/usr/X11R6/include/freetype2 -I/usr/local/include/SDL
> -D_THREAD_SAFE -I/usr/X11R6/include    -DMPG12PLAY  -o vo_gl2.o vo_gl2.c
> vo_gl2.c: In function `config':
> vo_gl2.c:948: error: `TEXTURE_FORMAT_ALWAYS' undeclared (first use in this
> function)
> vo_gl2.c:948: error: (Each undeclared identifier is reported only once
> vo_gl2.c:948: error: for each function it appears in.)
> vo_gl2.c:949: error: `TEXTURE_FORMAT_ALWAYS_S' undeclared (first use in this
> function)
> gmake[1]: *** [vo_gl2.o] Error 1
>
> 	Couple missing '_' characters.   Trivial patch to change the two
> 	lines.
>
> 	Cheers,
> 	Steven Schultz
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>