[MPlayer-dev-eng] [PATCH] pc2tv/tv2pc conversion

[Nico Sabbi]

Il gio, 2004-07-08 alle 02:36, Michael Niedermayer ha scritto:
> Hi
> 
> On Wednesday 07 July 2004 19:53, Nico Sabbi wrote:
> > This patch extends vf_yuvcsp.c to rescale luma and chroma when
> > converting from tv->pc and viceversa.
> >
> > Now the filter accepts an optional parameter which can be "pc2tv",
> > "tv2pc" or "clamp" (the default, old algorithm).
> >
> > It's implemented as a LUT for performance reasons.
> >
> > As far as I understand how CCIR601 works, this code seems to be correct,
> > but I wish someone more familiar with colorspace conversions will give
> > it a look.
> did u look at the tables? dont u think the pc2tv tables look strange?
> 

because of these sudden jumps from 0xd9 to the top?

0xd7, 0xd8, 0xd8, 0xd9, 0xeb, 0xeb, 0xeb, 0xeb,



> btw, ideally the code should do some dithering instead of rounding each sample 
> to the nearest color, because this introduces systematically duplicate / 
> missing colors, which is vissible if the gamma correction is broken for 
> example
> 
> [...]