[MPlayer-dev-eng] Re: [PATCH] mga_vid for 2.6 - updated...again

[Ferdinand O. Tempel]

On Tue, 2004-07-13 at 22:50, Ferdinand O. Tempel wrote:
> With respect to the problem of getting the MGA card detected in some
> systems, it seems that removing the CFLAGS line in the Makefile fixes
> that problem for some. I got one report back of the module failing to
> compile with that as workaround, but that too I haven't been able to
> reproduce. This issue is bugging me to no end, and the more information
> I gather (thanks guys!), the more confusing it gets. For those who want
> to try, I attached a patch against the Makefile too, to remove the
> CFLAGS. Besides, most of those already get passed on to the module build
> by the kernel's kbuild anyway (build with `make V=1` to see more
> output).

To reply to my own email: Peter Schuller has figured out that when
CFLAGS is turned into the form of CFLAGS+= that it has the same effect
of removing it altogether. The best guess I, and some others with me,
have now is that my CFLAGS= overrides some important stuff, which makes
PCI detection fail in some cornercases. Don't ask me why, I have no idea
either :-)

Anyway, I've made a new patch for the brave, which turns CFLAGS= into
CFLAGS+=.

Are you folks getting tired of me yet?

-- 
Regards,

Ferdinand O. Tempel

Your friendly neighborhood linuxops.net administrator.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mga_vid-2.6-makefile.patch
Type: text/x-patch
Size: 481 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040713/25c95253/attachment.bin>