[MPlayer-dev-eng] [PATCH] new codec AIFF PCM Audio support

[Ivan Kalvachev]

Jake Luck said:
>
> * added AIFF PCM playback
> * properly skips Apple's embedded ID3 tags
> * supports 16bit 44.1kHZ (for now)
> * diffed against latest CVS
>
> enjoy.
>
> jake_______________________________________________

Just few remarks before audio maintainer say hims word about
the code.

I noticed that you are using tab, in some places the indenting was
crazy jumpy. Pleace convert to spaces.

You are using 0x6669612e that is ".aif" (or "fia.").
probably it would be better to use an valid FourCC or
combination that could not be legal FourCC.

MPlayer is GPL project and I am not sure what is the point of
inserting BSD license inside it, especially if you are the
copyright holder. These files will not be accessable as BSD
and we may need to add GPL header after them (I think I have
saw that in the kernel sources. I may be wrong).

Wish You Best
   Ivan Kalvachev
  iive