[MPlayer-dev-eng] [PATCH] Load af_volume when needed

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Jul 19 17:32:29 CEST 2004


Hi,
> This small patch loads af_volume whenever needed. I.e. in the case where 
> the ao doesn't support volume, and it isn't already loaded. With this 
> patch, ao_macosx has volume support out of the box :)

Yes, this would be useful, I just didn't get to do it up to now.
First question: wouldn't it make more sense to add this to the 
set_volume function? I'd prefer if the volume filter didn't slow down 
things for people who don't actually need it. You might have to modify 
get_volume to return 90.0 by default when it can't get the volume...

I'd also like to have some status messages, replacing the 
MSGTR_NeedAfVolume message like e.g. "inserting af_volume for software 
volume control" and "couldn't insert af_volume".

Thanks for your efforts.

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list