[MPlayer-dev-eng] Re: [PATCH] Play longest track of a DVD - list DVD length

[adland]

> With this patch you can launch mplayer with  dvd://-1 and it plays the longest 
> track it founds.
> Launched with dvd://-2 it lists all the title with the lenght, number of 
> chapter, subtitles and languages.
> 
> Launched with dvd://-3 it make both (list title and play longest).

the usage of your patch overrides another pre existing usage.
that is dvd://-2 now means play tracks 1 and 2
and dvd://-3 now means play titles 1,2, and 3
etc...

this is all done in the command line parsing before opening the DVD.


> I tested it only on mplayer but it probably works also with mencoder (even if 
> it's, in my opinion, wrong: if you encode a title you MUST know wath you are 
> doing).
> 

Question when did you test your patch? I tested and it failed to get executed.

dvd://-1 should return an error (since 1-1 is not a range of tracks you would
just type in dvd://1 or dvd://)

and you would never have negative track numbers in open.c which you are
expecting for your patch to function.

some other patch updates would be needed
change for all your printf to use the mp_msg format instead (see many examples
in same file).

thanks