[MPlayer-dev-eng] [PATCH] mencoder psnr segfaults on readonly fs

Michael Niedermayer michaelni at gmx.at
Tue Jul 20 14:07:52 CEST 2004


Hi

On Sunday 18 July 2004 07:46, attila wrote:
> On Thu, Mar 11, 2004 at 04:43:49PM +0100, Fabio Russo wrote:
> > Hi,
> > after trying to execute mencoder in a read only fs (or, better, when the
> > user hasn't the write permissions) with the psnr option, it actually
> > segfaults when trying to fprintf on psnr.log. Attached is a simple fix
> > that will call mp_msg and let mencoder continue his job.
> > The same problem should happen in ve_xvid.c, ve_xvid4.c and vd_ffmpeg.c
> > (none of them tested), so maybe a more elegant solution should be
> > adopted.
> > Time for a question: should mencoder stop its execution if it can't
> > write to the log file? If you are encoding only for testing and after
> > some time you _don't_ have the log...
>
> Michael, could you please comment this patch ?
applied

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en




More information about the MPlayer-dev-eng mailing list