[MPlayer-dev-eng] [PATCH] FRIBIDI fix (subreader.c)

Diego Biurrun diego at biurrun.de
Tue Jul 20 16:39:57 CEST 2004


attila writes:
> On Thu, Jun 17, 2004 at 02:01:43PM +0200, Diego Biurrun wrote:
> > Eliran Gonen writes:
> > > Just to make things more clear:
> > > 
> > > Most windows subtitles displayer doesn't show up hebrew subtitles correctly,
> > > this makes hebrew subtitles writers to intentionally misplace commas and 
> > > dots
> > > so they will display correctly on screen. Most hebrew subtitles are this 
> > > way and
> > > the fix I just sent should "correct" it. Anyway, I'm planning to write 
> > > something that
> > > will let the user himself decide wether the subtitle file is "correct" 
> > > (commas, dots, etc
> > > placed correctly) or not, switching between :
> > > 
> > >    base = FRIBIDI_TYPE_ON;
> > > 
> > > and
> > > 
> > >    base = FRIBIDI_TYPE_L;
> > > 
> > > As soon as I will finish it, I will send a diff file. In the meantime 
> > > the above solution should
> > > do it as most if not all hebrew subtitles are written that way.
> > 
> > What happened to the patch you wanted to send along?
> 
> Yes, what happend to this patch ?

Just drop it.  He'll either send along a patch or never have his
feature.

Diego




More information about the MPlayer-dev-eng mailing list