[MPlayer-dev-eng] [PATCH] mplayer memory leaks

attila attila at kinali.ch
Thu Jul 22 09:19:21 CEST 2004


On Wed, Jul 21, 2004 at 03:16:24PM +0200, Alexander Strasser wrote:
> as suggested to me by the mkv devels on LinuxTag, I tested
> MPlayer for mem leaks with valgrind.
> 
> There were plenty of detected memory leaks in it's
> output some may not be real leaks because valgrind can be
> fooled by optimizations.
> But others as the ones this patch fixes are real ones.
> 
> So as a first start i eleminated the mem leaks caused by
> false use of the get_path() function.

Checked it, looks ok, can be applied.


> As a second step i wrote a little src documentation for
> get_path() also attached.

> + * Return Values:
> + *   Returns the pointer to the ALLOCATED buffer containing the
> + *   zero terminated path string. This string has to be FREED
> + *   in the callers scope.

Small rewording:

"This string has to be freed by the caller"

"scope" is here rather confusing then helping


			Attila Kinali




More information about the MPlayer-dev-eng mailing list