[MPlayer-dev-eng] [PATCH] mplayer memory leaks

Diego Biurrun diego at biurrun.de
Thu Jul 22 16:56:25 CEST 2004


Alexander Strasser writes:
 > On Thu, Jul 22, 2004 at 04:19:21PM +0900, attila wrote:
> > On Wed, Jul 21, 2004 at 03:16:24PM +0200, Alexander Strasser wrote:
> > > As a second step i wrote a little src documentation for
> > > get_path() also attached.
> > 
> > > + * Return Values:
> > > + *   Returns the pointer to the ALLOCATED buffer containing the
> > > + *   zero terminated path string. This string has to be FREED
> > > + *   in the callers scope.
> > 
> > Small rewording:
> > 
> > "This string has to be freed by the caller"
> > 
> > "scope" is here rather confusing then helping
> I don't think that scope ist fully wrong, but you are right it is
> too confusing in this context. I also made another error and wrote
> string in the last scentence, that should better be called buffer.
> 
> I attached a corrected version.

BTW, I think it's time to give you CVS write access.  You have sent a
few good patches, you are the maintainer of x11_common.c and you
appear willing to stick around.  Alex just agreed to this on IRC and I
doubt anybody will have objections (if not, voice them now or be
silent forever ;-).

So send Arpi a mail with your login and (first) password and read
DOCS/tech/cvs-howto.txt if you haven't already.  As a first action you
can add yourself to the AUTHORS and MAINTAINERS file and commit this
patch now that Attila approved it.

Diego




More information about the MPlayer-dev-eng mailing list