[MPlayer-dev-eng] [PATCH] encoding MP2 with Toolame

[Dominik 'Rathann' Mierzejewski]

On Sunday, 25 July 2004 at 16:17, Nico Sabbi wrote:
> 
> This patch permits to encode to mp2 using Toolame
> (a much better encoder than libavcodec).

Are there any test results to support your statement?

> You need a librarized version of toolame, such as 0.2m-beta-*
> available here http://users.tpg.com.au/adslblvi/
> 
> At the moment only CBR is supported; there is some support for vbr
> encoding,
> but it doesn't work yet.
> 
> In mencoder.c I copied all the AVI specific assignments from
> the code that calls libavcodec; I'm not familiar with that
> abomination, so I hope someone will review that code (TIA :) )
> 
> The requisites are:
> 
> - during configure you have to pass --with-toolamedir parameter (where
> you compiled toolame), e.g.:
> 
> ./configure --with-toolamedir=/path/to/toolame/libtoolame/

Can't you make this optional? Configure should search for toolame in standard
system libdirs and includedirs first.

R.

-- 
MPlayer RPMs maintainer: http://greysector.rangers.eu.org/mplayer.html
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"