[MPlayer-dev-eng] [PATCH] Updated JACK audio output driver

[Attila Kinali]

On Tue, Jun 22, 2004 at 08:35:36PM +0200, Kamil Strzelecki wrote:
> On 11:13 22.06.2004, Reimar Döffinger wrote:
> > I just saw that your indentation style is quite inconsistent (mixing 
> > spaces with tabs. Probably you can't see it in your editor, but in 
> > Mozilla this is quite obvious:

To repeat here the policy about white space changes (which indentation
patches are):
* Functional changes and whitspace changes should be always separated.
  Aka, functional patches should never contain white space changes and
  indentation patches should never contain functional changes.
* You may only reindent your own code, reindenting other people
  code is a big no-no (and may lead to removal of cvs access)

> Hmm I always use tabs for indentation, those spaces probably left from
> ao_arts which I used as a start point.
> 
> > You might consider using indent (as long as the code isn't in CVS)... I 
> > always use
> > indent --no-tabs --braces-on-if-line --braces-on-struct-decl-line 
> > --cuddle-do-while --cuddle-else --dont-break-procedure-type 
> > --case-indentation2
> > but feel free to find a combination that fits your style...
> 
> I've tried this out but it seems that for me it makes currently more mess
> with the code that it was before. I have no time now to find the option set
> suitable for me, but someday I should, it's very nice tool.

I compiled one for the x11 code once, took a while.
vo_xv, vo_x11, xmga, x11_common were reindented recently using it.
If you want i can make it available somewhere (maybe in cvs ?)

			Attila Kinali