[MPlayer-dev-eng] [PATCH] mplayer/metacity fs bug

Diego Biurrun diego at biurrun.de
Wed Jun 2 04:35:34 CEST 2004


Curtis Magyar writes:
> On Tue, 2004-06-01 at 09:00 +0900, Attila Kinali wrote:
> > >  
> > > +/*** EWMH state actions ***/
> > > +#define _NET_WM_STATE_REMOVE        0    /* remove/unset property */
> > > +#define _NET_WM_STATE_ADD           1    /* add/set property */
> > > +#define _NET_WM_STATE_TOGGLE        2    /* toggle property  */
> > 
> > 
> > Please rename these 3 defines to MP_X11_NET_WM...
> > Otherwise it looks ok. Diego, could you apply this patch
> > if nobody has any objections ?
> > Thanks
> 
> Sorry to butt in, I am very happy someone took the time to track down
> this bug.  I think the naming should remain the way it is though, as
> thats how it is in the EWMH spec:
> 
> http://freedesktop.org/Standards/wm-spec/index.html#id2768769

OK, patch kept the way it was with this link added to a comment and
applied.
Thanks

Diego




More information about the MPlayer-dev-eng mailing list