[MPlayer-dev-eng] Re: [PATCH] don't skip first mp3 frame

[D Richard Felker III]

On Tue, Jun 08, 2004 at 09:19:55PM +0200, Michael Behrisch wrote:
> On Mon, May 31, 2004 at 04:22:57PM -0400, D Richard Felker III wrote:
> > > 
> > > it's CF for win32, but i thought 'patch' strips these
> > > automatically, hmm, oh well, anyways here it is, again, hopefully
> > > it's ok
> > 
> > Was this patch ever applied? IIRC at the time I refused to commit it
> > myself because I couldn't do thorough tests, but it looks right.
> > Anyway, no one seems to be stepping forward to test, so I'm going to
> > commit this soon and let our users do the testing after the next
> > release... :))
> 
> I would rather have You apply my patch, which I sent several times
> to Albeu (even to his private mail) but he did not answer.
> It checks better for valid mp3. It does clean up the double removal
> of the first frame (in demux_audio and mp3lib) and if you wish
> I can modify the patch such that it also removes the first
> frame skipping in mp3lib.

Does anyone else have comments on this patch? Can you explain why it's
better than the other one?

Rich