[MPlayer-dev-eng] [PATCH] Gnome menu icon for debian

[Diego Biurrun]

scognito at libero.it writes:
> Again the patch, with the desktop file included.
> Sorry for the inconvenience,
> --- debian/CVS/Entries	2004-06-21 18:07:03.000000000 +0200
> +++ debian.mio/CVS/Entries	2004-06-21 16:31:14.000000000 +0200

This file should not be included in the patch.

> --- debian/rules	2004-06-21 18:07:03.000000000 +0200
> +++ debian.mio/rules	2004-06-21 16:08:12.000000000 +0200
> @@ -52,6 +52,10 @@
>  
>  	# commands to install the package into debian/<packagename>
>  	$(MAKE) prefix=$(prefix)/usr BINDIR=$(prefix)/usr/bin CONFDIR=$(prefix)/etc/mplayer LIBDIR=$(prefix)/usr/lib DATADIR=$(prefix)/usr/share/mplayer  MANDIR=$(prefix)/usr/share/man  install
> +
> +	install -m 644 -o 0 -g 0 etc/mplayer.desktop $(prefix)/usr/share/gnome/apps/Multimedia/mplayer.desktop
> +	install -m 644 -o 0 -g 0 Gui/mplayer/pixmaps/MPlayer_mini.xpm  $(prefix)/usr/share/icons/MPlayer_mini.xpm

Hmm, what happens if there is GNOME installed and these directories do
not exist?  I think make install will fail, so there should be some
kind of check that verifies it is safe to execute the commands.

> --- /dev/null	2004-05-30 00:45:55.000000000 +0200
> +++ etc/mplayer.desktop	2004-06-21 17:29:29.000000000 +0200
> @@ -0,0 +1,14 @@
> +[Desktop Entry]
> +Name=MPlayer
> +Comment=The movie player for linux

The Movie Player For Linux

> +Comment[de]=Multimedia player

Multimedia Player

> +Comment[es]=Reproductor multimedia
> +Comment[fr]=Lecteur multimedia
> +Comment[it]=Lettore multimediale 

Remove the trailing blank.

> +Comment[us]=Multimedia player
> +Exec=gmplayer
> +Icon=/usr/share/icons/MPlayer_mini.xpm
> +Terminal=0
> +MimeType=video/mpeg;video/quicktime;video/x-msvideo;audio/x-mp3;audio/x-mp2;

Is this a list of mime types that MPlayer can play or will MPlayer
become the default player for them?  In the former case there are a
few more that could be added, in the latter case I suggest only adding
video mime types.

Diego