[MPlayer-dev-eng] [PATCH][RESEND] XV page flipping sync

Diego Biurrun diego at biurrun.de
Tue Jun 22 10:42:09 CEST 2004


Reimar Döffinger writes:
> 
> > 01:44 <@KotH> DonDiego: whether it catches all XFlush calls
> > 01:44 <@KotH> DonDiego: if he is right, then there should be no XFlush in the x11 code
> 
> vo_gl ang vo_gl2 use constructs like
> 
>          XFlush(mDisplay);
>          XSync(mDisplay, False);
> 
> My theory was always that the XFlush is rather useless. Am I correct? 
> Should they be removed as well? (The problem described in the original 
> mail can't happen here, as XSync is called as well).

Been talking to Attila on IRC again:

02:50 <@KotH> DonDiego: imho, the patch should be extended to
              xv/x11/x11_common, then it's ok to apply
02:51 <@KotH> DonDiego: and to answer reimars question: according to the
              manpages, doing xflush+xsync is useless, xsync alone is enough

So could somebody extend this patch?

Diego




More information about the MPlayer-dev-eng mailing list