[MPlayer-dev-eng] [PATCH] Updated JACK audio output driver

[Reimar Döffinger]

HI,

> While fixing bug submitted today I found another. :/ Both are dead now. :]
> Updated version of the patch included.

I just saw that your indentation style is quite inconsistent (mixing 
spaces with tabs. Probably you can't see it in your editor, but in 
Mozilla this is quite obvious:

e.g. here:
> +		case AFMT_S8:
> +		    format = AFMT_U8;
> +			bits_per_sample = 8;


and here:

> +		}
> +    }
> +	/* any other error */
> +	else if(err != ERR_SUCCESS) {
> +	  mp_msg(MSGT_AO, MSGL_ERR, 
> +			  "AO: [Jack] JACK_Open() failed, error %d\n", err);
> +      return 0;
> +	}
> +	

You might consider using indent (as long as the code isn't in CVS)... I 
always use
indent --no-tabs --braces-on-if-line --braces-on-struct-decl-line 
--cuddle-do-while --cuddle-else --dont-break-procedure-type 
--case-indentation2
but feel free to find a combination that fits your style...

Greetings,
Reimar Döffinger