[MPlayer-dev-eng] Re: mplayer UDP port number
John Earl
jwe21 at cam.ac.uk
Sat Mar 6 18:31:16 CET 2004
Marc Hoffman wrote:
>
> Ok what I have done is added a new video out driver for raw video
dumping.
>
> static vo_info_t info =
> {
> "RAW file eyuv I420",
> "raw",
> "mmh",
> ""
> };
>
> This has been done in much the same way that pgm files are dumped.
>
> and to use it lets say you type
>
> mplayer tennis.bits -vo raw
>
> Do I just add this file, I don't think I have CVS ACCESS for 1 and
> secondly who reviews changes?
Doesn't my raw video mux patch from 2 weeks ago (attached, relevant
email included below) do what you want, if taken together with the
ve_raw patch already committed a month ago? How is your method
materially different -- ie, why do you need to be doing this with
mplayer when you could equally well use the facilities in mencoder?
John
-------- Original Message --------
Subject: Re: [MPlayer-dev-eng] Re: Why is the
mplayer-1.0pre3-dumpvideo.diff patch not applied?
Date: Mon, 23 Feb 2004 23:28:28 +0000
From: John Earl <jwe21 at cam.ac.uk>
To: mplayer-dev-eng at mplayerhq.hu
References: <20040208223620.0A82D2F9C5 at mail.mplayerhq.hu>
<403A081E.6060804 at cam.ac.uk> <20040223221551.07f5e7b5.attila at kinali.ch>
<403A718E.8020808 at cam.ac.uk>
<20040223222328.GA17336 at melchior.yamamaya.is-a-geek.org>
Revised patch attached - any other comments?
Tobias Diedrich wrote:
> John Earl wrote:
>>Sorry, didn't think the patch would be wanted! There was already an
>>online help string (using -of help) but have added a couple lines to the
>>man page in new version, attached.
>
>
> I think rawvideo would be a better name. :-)
> And I think I'm probably not the only one who will find this patch
> useful, especially for mpeg encoding scripts.
I agree. Done.
Have you actually tried it to make sure it does what you expect with
compressed streams? (I'm only using it with -of rawvideo -ovc raw)
>>+static void write_raw_chunk(FILE *f,int len,void* data){
>>+ if(len>0){
>>+ if(data){
>>+ // DATA
>>+ fwrite(data,len,1,f);
>>+ } else {
>>+ // JUNK
>>+ char *avi_junk_data="[= MPlayer junk data! =]";
>>+ if(len&1) ++len; // padding
>>+ while(len>0){
>>+ int l=strlen(avi_junk_data);
>>+ if(l>len) l=len;
>>+ fwrite(avi_junk_data,l,1,f);
>>+ len-=l;
>>+ }
>>+ }
>>+ }
>>+}
>
>
> You can drop the junk path.
The attached patch loses the junk path as suggested.
>>+ if((unsigned int)len>s->h.dwSuggestedBufferSize) s->h.dwSuggestedBufferSize=len;
>
>
> This line should be unneeded too.
Ok, done. I wasn't careful enough to work out where else
dwSuggestedBufferSize might be used.
J
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-rawmux.patch
Type: text/x-patch
Size: 8015 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040306/bb381ddd/attachment.bin>
More information about the MPlayer-dev-eng
mailing list