[MPlayer-dev-eng] ALTIVEC accelerated YUV2RGB

[Marc Hoffman]

On Mar 15, 2004, at 10:33 AM, Nicolas Plourde wrote:

> Romain Dolbeau wrote:
>
>> Marc Hoffman wrote:
>>
>>> I hope that this meets more of the needs of this group.
>>>
>>> I still kick out and defer to C codes to handle the border cases img 
>>> sizes not multiples of 16.  I will work on that next weekend.
>>
>>
>> I have a problem. I tried your patch w/ the experimental
>> vo_quartz that was posted a while ago, and I see a
>> distinctive yellow tint on the entire picture. Something
>> is definitely wrong here (w/o you patch, the movie displays
>> just fine).
>>
>> w/o the patch:
>> #####
>> No accelerated colorspace conversion found
>> SwScaler: using unscaled Planar YV12 -> RGB 32-bit special converter
>> #####
>>
>> w/ the patch:
>> #####
>> ALTIVEC: Color Space RGB32
>> SwScaler: using unscaled Planar YV12 -> RGB 32-bit special converter
>> #####
>>
>> So I guess it does pick up your functions...
>>
> Any good speed improvement with this patch using vo_quartz?
> Is it faster over qt framework color space conversion, because it
> what i was planning to us?. I will probably send an update to my
> patch soon also with some speed improvement.
>
> ---
> Nicolas Plourde

yes its faster. no benchmarks yet still trying to iorn out all of the 
details.

BTW if I just remove the alpha positioning the two components seem to 
work like a charm, I use this instead of specifying skip first.
                    draw_slice:
			alphaInfo = kCGImageAlphaNone;