[MPlayer-dev-eng] Re: OpenDML Read/Write support

[Nico]

Jindrich Makovicka wrote:

> D Richard Felker III wrote:
>
>> On Sun, Mar 21, 2004 at 06:16:34PM +0100, Jindrich Makovicka wrote:
>>
>>> Tobias Diedrich wrote:
>>>
>>>> This updated patch now includes Video Property Header support (Among
>>>> other things stores aspect ratio).
>>>> However neither Window Media Player nor Media Player Classic seem to
>>>> support it...
>>>
>>>
>>> Nice, now the aspect encoding goes totally bogus :)
>>>
>>> When I encode a mpeg2 dvb capture (4:3) and crop to 16:9, the 
>>> resulting file is has still 4:3 in the header, and stuff like 
>>> -noaspect or specifying aspect in -lavcopts doesn't make any change.
>>
>>
>>
>> Arrgg, 1000000000l!!!!! You have to get the aspect from the END of the
>> video filter chain, not from movie_aspect!
>>
>> Someone remove or fix this brain damage asap!
>
>
> I vote for the removal, as lavc can encode/decode its own aspect 
> headers, and this patch effectively disables already available method 
> of specifying the aspect ratio. I already have a working patch with 
> the bogus parts commented out with #ifdefs, should I commit?
>

Please, don't remove it: if fixed it's useful. There are players that 
understand the AR header in avi
but not  in the video stream.
Maybe enabling it with a suboption is the right way to go.
       Nico