[MPlayer-dev-eng] Re: [PATCH] don't skip first mp3 frame

[Alban Bedel]

Hi Nehal,

on Mon, 22 Mar 2004 11:55:03 -0800 you wrote:

> Albeu: skipping the first 2 frames is a bad fix either way. 
> fixing one bug by adding another is not right. even if it doesn't fix
> mp3lib, the first 2 frames should play, otherwise it breaks all 
> other mp3 decoders (ie, ffmp3) that work fine. if you wanted a 
> temporary fix, the first 2 frames should have been skipped from  
> the mp3lib code only.

I never claimed that it was a good fix. And when the mp3 demuxer was
written ffmp3 was slow as hell so no one used it.

> but it seems everything was fine for me were fixed when i removed 
> _both_ 2 frame skips, (my patch + comment out  ad_mp3lib.c:49, 
> MP3_DecodeFrame(NULL,-2);  ) if anyone has any mp3's that still pop 
> after this, please send to me (at least the first couple of seconds) 
> so i can fix.

I look at this tomorow, but i bet it won't be long before i find some
files wich will be initialized with wrong params.
	Albeu
-- 

Everything is controlled by a small evil group
to which, unfortunately, no one we know belongs.