[MPlayer-dev-eng] Re: [Patch] Audio detection

[Arpi]

Hi,

> Hello,
> I forgot to mention that my patch might also solve nehals problem,
> at least it does not skip the first frame if it is followed by valid 
> ones. So please apply ;-)
> 
> Michael

many mp3 files has bad first frame.
the most common cases are ascii art/nfo file in fake 2048 bytes frame
at the beginning of the file, and the xing vbr header.

they must be skipped before the decoder gets the samplerate/channels etc
info from them.

anyway i see there is a big problem: where should it be skipped?
in the demuxer? easy to do in demux_audio, but what about mp3 tracks
of avi, ogm etc?
in the codec? then at least mp3lib, libmad and libavcodec should be
able to do it. currently (afaik) only mp3lib skips the first frame.


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu