[MPlayer-dev-eng] [PATCH] make wmv9 playback less verbose

[Michael Niedermayer]

Hi

On Friday 26 March 2004 04:12, D Richard Felker III wrote:
> On Fri, Mar 26, 2004 at 03:54:19AM +0100, Diego Biurrun wrote:
> > Hi!
> >
> > When playin wmv9 videos the console gets spammed badly with messages
> > like this:
> >
> >   Win32 Warning: Unlocking unlocked Critical Section 0x864fb18!!
> >
> > These messages are more confusing than helpful and they come by the
> > hundreds, which makes them annoying.  This patch changes the printf
> > calls to dbgprintf calls, which makes the messages appear only when
> > mplayer is called with -v -v.
> >
> > IIRC there have been complaints about these messages on -users and
> > here also.  I'd like to commit this, if there are no problems, so
> > somebody please check it.
>
> IMO commit. these stupid printf's at least need to be replaced with
> something. All the printf mess should be removed so we can eventually
> use stdout...
sure but that patch doesnt look correct:
     FF(RegCloseKey, -1)
-    FF(RegCreateKeyA, -1)
     FF(RegCreateKeyExA, -1)
...
is it just me or does this patch change a few unrelated things like:
-  if (!strcmp(library, "tsd32.dll") || !strcmp(library,"vssh264dec.dll") || 
!strcmp(library,"LCMW2.dll"))
+  if (!strcmp(library, "tsd32.dll") || !strcmp(library,"vssh264dec.dll"))

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en