[MPlayer-dev-eng] Re: [PATCH] libcaca native support

[Alban Bedel]

Hi Pigeon,

on Sat, 27 Mar 2004 17:05:33 +1100 you wrote:

> 
> > If libcaca can take an image of "any" size then you should not include
> > the sofware scaler inside tho vo. I know the libaa vo do it, but it's
> > bcs libaa want a specific resolution. Otherwise it seems ok.
> 
>     Alright, here is the full patch again, with sws taken out.

Good.

>     I suppose one thing I'm not 100% sure is that, how safe it is to
> simply draw with the src data passed to draw_frame/draw_slice. I see
> most other vo plugin codes make a copy of src data into its own image
> data buffer, and then draw it later (normally with memcpy, which is
> slow).

It's allright. I suppose those vo how add a memcpy have either no
choice or are badly coded :(

Something else come up to my mind. You intercept key press like vo aa
does. If possible it would be nice to use commands for that, like it's
done for contrast,brigthness, etc controls. Dunno what other think about
this, but personaly i don't like that vo intercept key press as it can
screw up ppl wich use non-standard key config.
That is absolutly not a critical issue, but in my experience if that
doesn't get fixed from the start it's never done :(

	Albeu
-- 

Everything is controlled by a small evil group
to which, unfortunately, no one we know belongs.