[MPlayer-dev-eng] ftp support broke in pre4?

[Roberto Togni]

On 2004.05.02 02:07, Compn wrote:
> ftp support broke in pre4? was testing out adlands' url
> escape patch with rxt when we find ftp support not working.
[...]
pre4
> Unknown protocol 'ftp'
> Unable to open URL:
> ftp://upload:upload@24.169.238.111:5556/moby_in_this_world.r
> m
> Exiting... (End of file)

pre3
> Unknown protocol 'ftp'
> Unable to open URL:  
> ftp://upload:upload@24.169.238.111:5556/moby_in_this_world.r
> m
> WINSOCK2 init: 0
> Connecting to server 24.169.238.111[24.169.238.111]:5556 ...
> [ftp] < 220-GuildFTPd FTP Server (c) 1997-2002

Both print the error message that ftp is unknown protocol and are  
unable to open url.
That's the reason of the problem: ftp requires that open_stream does  
not halt on connection errors, but continues to open_stream_full at the  
end of the function. that's because ftp is handled differently from  
other protocols.

Support was broken by a patch (v1.91 v1.92 27/04/2004 13.19.20) that  
uncommented code to exit from open_stream on connection errors, to  
remove bogus error messages (host do not have a domain part and such).

This patch should fix it without restoring bogus messages.

Please test.

Ciao,
 Roberto
-------------- next part --------------
A non-text attachment was scrubbed...
Name: open.c.diff
Type: text/x-patch
Size: 706 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040502/c654e1a0/attachment.bin>