[MPlayer-dev-eng] [PATCH] sync libfaad2 CVS 5-1-04 large

[D Richard Felker III]

On Sun, May 02, 2004 at 11:52:59PM +0000, adland wrote:
> tried to make a patch whcih syncs the libfaad2 code with
>  latest CVS from 5-1-04.
> 
> Cannot post to mailing list due to size.
> 
> you can download from below for now
> 
> http://adland123.tripod.com/libfaad2_sync.tgz
> 
> the patch file is packed with tar and gzip .
> 
> a few files are no longer required in this version.
> 
> compile worked and all compile issues seemed to go away for me.
> 
> could someone help with this (testing/samples/reports).

I'm hesitant to have this applied. I've been trying to fix up the
brain damage of faad myself, and lots of this patch conflicts (and
does not help, just makes cosmetic changes). I went to great lengths
to remove all the uint16_t's from cfft.c and several other files, as
well as adding some better fixed point asm for x86.

Anyway, I got the cpu usage down from 95% to 33% by #define'ing
FIXED_POINT and making these changes, but it's still way too slow.
Further progress seems to be blocked by the fact that faad's horrible
code is destroying the cache. So now we need to decide what to do:

- Try to keep up with upstream faad and hope they fix the horrible
  performance. (Not likely since they're windows morons...)

- Apply my patches and forget about sync with upstream.

- Beg someone to write an AAC decoder for libavcodec and remove this
  shitty code from MPlayer cvs entirely.

I vote for #3, but who will volunteer...? :((

Rich