[MPlayer-dev-eng] PATCH RFC frameno options with cdsize

[D Richard Felker III]

On Mon, May 03, 2004 at 06:11:12PM +0200, Jan Gutter wrote:
> On Mon, 2004-05-03 at 16:52, Reimar Döffinger wrote:
> > Hi,
> > I can't really comment, but while you're waiting for a reply (developers 
> > are currently a bit overloaded :-( ), there is a little thing you should 
> > change in your patch:
> > don't change the indentation of otherwise unchanged lines (even if it 
> > makes the code harder to read). This makes it hard to track changes in 
> > CVS (e.g. for bug-finding).
> 
> I'm in no great hurry, so this patch can really take a looooong while to
> get in (if ever!). Look, I wholeheartedly agree on the indentation-level
> thing if it would make the patch smaller (which it would!) and make CVS
> bug tracking easier. The only reason that it "looks" like the
> indentation is changed is because that's the fallback or "legacy"
> method. If I had my way, I'd drop all of those lines except one (700Mb)
> and put in a printf to say that -frameno cdsize=size is now available.

If I had my way, I would remove frameno support entirely. It's buggy
and causes A/V desync in lots of cases, and it's incompatible with
lots of filters. I don't mind leaving it in for expert users who
understand when to use it, but maybe we could make it print a
warning...?

Rich