[MPlayer-dev-eng] [PATCH] fix in screen resolution detection by the gui (correction)

[Reimar Döffinger]

Hi,

> +#ifdef HAVE_XF86VM
> +    {
> +      int clock;
> +      XF86VidModeModeLine modeline;
> +
> +      wsOrgX = wsOrgY = 0;
> +      XF86VidModeGetModeLine( wsDisplay,wsScreen,&clock ,&modeline );
> +      wsMaxX=modeline.hdisplay;
> +      wsMaxY=modeline.vdisplay;
> +    }
> +#endif
>   {
> - wsOrgX = wsOrgY = 0;
> - wsMaxX=DisplayWidth( wsDisplay,wsScreen );
> - wsMaxY=DisplayHeight( wsDisplay,wsScreen );
> +   if ( !wsOrgX ) wsOrgX = 0;
> +   if ( !wsOrgY ) wsOrgY = 0;
> +   if ( !wsMaxX ) wsMaxX=DisplayWidth( wsDisplay,wsScreen );
> +   if ( !wsMaxY ) wsMaxY=DisplayHeight( wsDisplay,wsScreen );

I guess from your last post that you intend to add some improvements 
later on, but could you nevertheless leave that line:
wsOrgX = wsOrgY = 0;
where it is? (and remove those "if ( !wsOrg..)" lines) Better to avoid 
unnecessary (and IMHO irritating) changes.

>  {
>   int decoration = 0;
> -
>   if ( win->isFullScreen )
>    {

That's not good (cosmetics)...

Greetings,
Reimar Döffinger