[MPlayer-dev-eng] [PATCH] EDL cleanup and fixes

[Reynaldo H. Verdejo Pinochet]

On Wed, Nov 03, 2004 at 12:01:50AM +0200, Oded Shimon wrote:
> This patch both cleans up the EDL code a bit (The way it was written before 
> was either genius or insane. Because I couldn't make any sense of it), and 
> also fixed it up a bit so the EDL "censored" areas are _NEVER_ shown, no 
> matter what. Seek has been modified for this, so when seeked backwards to an 
> EDL area, time jumps to before the EDL area, and visa versa for forward 
> seeking. Also unmuting is impossible in EDL muted area, and if user mutes in 
> non muted area, this mute is stored so EDL doesn't unmute just because it 
> finished its muted area. (i.e., user mutes are stored)
> 
> I tested the patch in every way I could think of, worked for all cases.
> 
> - ods15
Please move all non code related changes to a separate patch, this
has been discused several times, now the mute, mixer_mute should be
replaced by a *real* mute function, keep coding around it will only
lead to a *this code should be pasted* state, this should be discussed.
you mention you can take care of mixer_mute, my idea is you do
it now, for the seeking while on edl, sounds ok with me as we have
discussed througly on #mplayerdev but you need to separate it from
te rest, same for doxygen fixes as i have stated early on this same
post.

when facing the genius or insane dilema, just assume you dont
understand it, as you have proved several times asking for
real basic questions on irc.

for now, isolate the seeking and doxygen parts, im willing to apply
that.

  Best regards

     Reynaldo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041102/8847843a/attachment.pgp>