[MPlayer-dev-eng] [PATCH] EDL cleanup and fixes

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Nov 3 18:25:15 CET 2004


Hi,
> > > > You dont need this (edl_muted), there is already an edl_mute_count
> > > > that does the same, if edl_mute_count%2 != 0 youre on edl's mute mode
> > >
> > > There, this is a new patch, its _identical_ to the previous one, except
> > > it uses:
> > > edl_mute_count & 1
> > > instead of:
> > > edl_muted

I know Reynaldo said so, but what good should using a counter be? It
seems to me that this only complicates code.

> +#ifdef USE_EDL
> +      user_muted = user_muted ? 0 : 1;

user_muted = !user_muted;
seems much clearer to me...

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list