[MPlayer-dev-eng] [PATCH] forceable software volume control

[Oded Shimon]

On Friday 05 November 2004 18:23, The Wanderer wrote:
> No, I've used the command I gave more than once in the past to compare
> files against CVS (including for creation of patches), and it's worked
> just fine. I've never had to specify a revision with MPlayer, and would
> be considerably surprised if it were suddenly necessary now.
I think you might still be a bit confused, or I am - CVS remembers when you 
downloaded your file from CVS. And the server remembers all the files from 
every time. So when you do a CVS 'diff', it doesn't compare with the most 
recent MPlayer, it compares with the files you _originally_ downloaded, so 
you can see ONLY the changes you made, and not the changes made in the CVS. 
This is its behavior at least for me...

> Just tested again, with a file I've modified myself towards the next
> patches in the printf --> mp_msg conversion, and the command I quoted
> above works just fine.
Of course it did, it showed you the changes YOU made, not the changes made to 
the CVS!

> Oh, wait - did you mean "modify manually" as in "edit by hand rather
> than by applying a patch"? If so, then you misinterpreted my comment
> above; "no differences" is *without* having applied the patch. (Also,
> comparing against another local source tree which is identical to CVS
> likewise reports no changes.)
No, I meant ANY changes made to your files which made it even different by 
hand.
Doing 'touch somefile.c' prevent CVS from even updating it again unless you 
force it to. Again, at least for me.

> Yes, and if there are no conflicts between any changes I made and the
> ones in the updated version, I want to keep my changes. If there are
> conflicts, then the file winds up in a non-compilable state, and I go in
> and make whatever edits are necessary to bring it into shape. (Usually
> that consists of removing the record of my own changes, but sometimes I
> want to either keep them anyway or combine them with the updated code.)
Usually when I want to update and keep my changes, I do this:
cvs -q -z3 diff -u > ../mp.patch
cvs -z3 update -C
patch --dry-run -p0 < ../mp.patch

That way I get the up-to-date files, with my changes, and I can see and fix if 
anything has changed that breaks my patches.

> The counter-argument to that, which he made recently on the -users list,
> is that raising the volume by more than about 10% causes extremely
> audible artifacting. I don't know if that's true - I certainly don't
> remember encountering such artifacting myself in all cases before
> reaching *much* higher volumes - but if so it does present a fairly good
> case for not going past that range by default.
I didn't notice such defects. lemme try again...
I managed to get to about 150% without noticeable defects. after that it 
becomes pretty noticeable and after 200% it becomes unbearable.

I personally have my hardware mixer always set to ~40% (VERY low, my hardware 
mixer is weird, 90% is like half), and my speakers always on max volume (the 
reason for this is an effective automated alarm clock...), using those 
settings I got to about 300% with barely noticing the defects.


>
> On a complete tangent, is there any particular reason why your posts
> specify the use of a Hebrew encoding scheme (ISO-8859-8-I)? I expect
> that sort of thing in cases where the text contains non-ASCII characters
> (i.e., posts with Japanese characters and the like, which I see not
> infrequently), but since you have so far been posting entirely in the
> Roman alphabet I'm wondering if there's something going on.
Heh, I didn't know it did that... I guess it grabbed it from system's language 
settings... I changed it, I think.. is it better now?

- ods15