[MPlayer-dev-eng] [PATCH] configure: deal with newer head's and tail's dislike of -1

Diego Biurrun diego at biurrun.de
Sat Nov 6 16:45:54 CET 2004


Sascha Sommer writes:
> On Friday 05 November 2004 22:44, Moritz Bunkus wrote:
> >
> > BTW: This patch is against configure rev 1.932 ! That's the one BEFORE
> > Colin Leroy committed his change to head/tail to always use '-n' because
> > I expect it to get reversed.
> 
> If it gets reversed please take care of the polypaudio configure checks, I 
> added afterwards. Didn't notice the broken commit before.
> I also have to say that I don't like reversing commits with cvs admin at all.
> Imho they might be ok if the commiter fucked up something during the commit, 
> like commiting to the wrong version or if he commited code that is not easy 
> to fix and breaks compilation. It should never be used for broken code 
> changes, because it somewhat works behind the back of the other developers.
> It also has something from a time machine. When we are super l33t coders
> in the future will we just reverse every file to   1.0 and rewritte MPlayer 
> from scratch without all the hacks?

100% agree.

Diego




More information about the MPlayer-dev-eng mailing list