[MPlayer-dev-eng] [PATCH] fix vf scale with negative values

[Michael Niedermayer]

Hi

On Friday 12 November 2004 00:58, Reimar Döffinger wrote:
> Hi,
>
> > > > This patch is to fix a problem when using scale with negative values.
> > > >  While scale=-1:-2 worked fine, scale=-2:-1 did not (though,
> > > > according to the man page, it should have).
> > > >
> > > > I've done a few minutes of testing with this patch, and it doesn't
> > > > seem to break anything, just fixes what was already broken.
> > >
> > > Are you sure it doesn't break scale=-1:-2? Anyway, this chaos-code
> > > should really be cleaned up. Having the same code (expect for the
> > > rounding) three times seems very bad to me.
> >
> > thanks for volunteering to clean it up :)
>
[...]
> +    if (vf->priv->w < -3 || vf->priv->h < -3 ||
> +         (vf->priv->w < -1 && vf->priv->h < -1)) {
> +      // TODO: establish a direct connection to the user's brain
> +      // and find out what the heck he thinks MPlayer should do
> +      // with this nonsense.
> +      mp_msg(MSGT_VFILTER, MSGL_ERR, "SwScale: EUSERBROKEN Check your
> parameters, they make no sense!\n"); 

:)

cvs commit!

[...]

-- 
Michael

"I do not agree with what you have to say, but I'll defend to the death your
right to say it." -- Voltaire