Re : Re : [MPlayer-dev-eng] [PATCH] -ao pcm suboptions

[Olivier Rolland]

Le 19.11.2004 19:58:39, The Wanderer a écrit :
> Olivier Rolland wrote:
> 
>> Le 19.11.2004 11:59:21, Diego Biurrun a écrit :
>> 
>>> However, you should remove the old option descriptions from the man
>>> page as well as adding the suboptions.
>> 
>> Done.
> 
>> +.IPs waveheader
>> +Include wave header.
>> +.IPs nowaveheader
>> +Don't include wave header.
>> +Used for raw PCM.
> 
> Shouldn't whichever of these is default (waveheader, I believe) be
> marked that way?

You're right.

>> +				pcm_filename = strndup (&ao_subdevice 
>> [parse_pos], file_len);
>> +				parse_pos += file_len;
>> +				fprintf(stderr, "%s\n", pcm_filename);
> 
> Instead of fprintf(stderr, ...), shouldn't this use mp_msg 
> (MSGL_CPLAYER,
> ...) or similar?

Never mind, this is some debuging code that I forgot to remove. Sorry.

New patch is attached.

Olivier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-pcm-options.patch
Type: text/x-patch
Size: 7061 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041119/4fc75461/attachment.bin>