[patch] RE: [MPlayer-dev-eng] [PATCH] directfb2 compilation without fbdev

Jiri Svoboda jiri.svoboda at seznam.cz
Thu Nov 25 00:00:24 CET 2004


> Ville Syrjälä writes:
> > On Fri, Nov 19, 2004 at 09:49:35PM +0100, Jiri Svoboda wrote:
> > > > vo_directfb2 won't work when vo_fbdev isn't compiled, 
> because the
> > > > fb_dev_name variable is missing. The attached patch adds it to
> > > > vo_directfb2 although it (currently) is not used.
> > > > Not sure if that's such a good idea, it might be better 
> to remove the
> > > > global fbdev option instead, but that would be more work.
> > > 
> > > No,
> > > just remove it from cfg-mplayer.h
> > 
> > That would break vo_directfb.c (not that anyone should 
> seriously be using 
> > it anyway)
> > 
> > The attached patch should make everyone happy. The 
> alternative would be 
> > removing both the fb_dev_name stuff and vo_directfb.c 
> (perhaps this would 
> > be the best option).
> 
> Didn't you want to remove vo_directfb.c a long time ago?  What's
> holding you up?

May I ask  somebody who is familiar with configure&shell stuff to look at
this patch? The patch should remove support for directfb<0.9.13 (really
outdated)... The patch touches only configure (removal vo_directfb.c file
itself is not included).

Thanks...

		JS
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure.diff
Type: application/octet-stream
Size: 1211 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041125/46127d5e/attachment.obj>


More information about the MPlayer-dev-eng mailing list