[MPlayer-dev-eng] [PATCH] x264 option renaming

[Diego Biurrun]

Loren Merritt writes:
> On Mon, 27 Sep 2004, Ivan Kalvachev wrote:
> 
> > Commited.
> > I have removed the variable change name, because:
> > 1. the local variable names are the same as the one used in x264 structure.
> > 2. it is considered cosmetic change and violate the MPlayer rules.
> 
> No problem. Just that the first time I submitted the patch,
> On Sat, 25 Sep 2004, Diego Biurrun wrote:
> > IMO (others may disagree) you should rename the variables as well,
> > having variable names and option names differ is a recipe for code
> > obfuscation IMO.
> ... and I took it as a suggestion.

And I am still convinced that not updating variable names when the
option names change is a recipe for code obfuscation.  Ivan what about
changing the variable names in a separate patch then?  Why are you
opposed to changing the variable names when the option names change as
well?

Diego