[MPlayer-dev-eng] Bug in aspect ratio calculation for theora

[Arpi]

Hi,

> Hi there,
> I am currently testing ogg theora encoding in LiVES 
> (http://lives.sourceforge.net)
> 
> There seems to be a problem calculating aspect ratios for this format.
> 
> With a movie size of 256x144 (aspect ratio of 16:9) I see the following:
> 
> VDec: vo config request - 256 x 144 (preferred csp: Planar YV12)
> VDec: using Planar YV12 as output csp (no 0)
> Movie-Aspect is 3.16:1 - prescaling to correct movie aspect.
> VO: [xv] 256x144 => 456x144 Planar YV12
> 
> 
> Now, (256 * 256) /  (144 *  144)  = 3.16049...
> 
> so it seems that somewhere mplayer is not taking a square root.

no need for square roots in aspect code, its linear transform.
probably it does the 16:9 aspect correction twice, probably once
in the demuxer (due to aspect value in container header) and
once in the codec (due to embedded aspect info in codec header).


A'rpi / MPlayer, Astral & ESP-team

--
MPlayer's new image: happiness & peace & cosmetics & vmiklos