[MPlayer-dev-eng] [PATCH] printf --> mp_msg transition (mplayer.c)

[The Wanderer]

Diego Biurrun wrote:

> The Wanderer writes:

>> Adds trailing periods to a few strings; may also correct a few
>> spelling errors, but I don't think I left anything like that in
>> this version of the patch.
> 
> Ideally, this would go in a separate patch.  But I'm not going to be
> too pedantic about this.

Yes, I generally agree. I wouldn't have changed them if I had known they
were going to be staying where they are, and now that I've thought about
it more might not change such in future even when moving them to the
translations file, but I figured as long as the work had been done I
might as well include it.

>> There are two MSGTRs of MSGL_V (AODescription_AOAuthor, AOComment)
>> in mplayer.c which were present before I did my work; for the
>> moment, I've left them alone. If I come across such things, which I
>> would not ordinarily change but which are inconsistent with the
>> rules I'm following, should I correct them as well?
> 
> Yes.

Acknowledged.

>>-       edl_mute_count++; // new EDL seek behavior needs this
>>+       edl_mute_count++; // new EDL seek behavior need this
> 
> This was correct before.

...Yes, it was. This looks rather like something I missed when syncing
my working tree with the changes Reynaldo had made (since cvs update
didn't manage the job quite correctly).

>>@@ -323,7 +361,6 @@
>> #define MSGTR_LavcAudioCodecNotFound "Audio LAVC, couldn't find encoder for codec %s\n"
>> #define MSGTR_CouldntAllocateLavcContext "Audio LAVC, couldn't allocate context!\n"
>> #define MSGTR_CouldntOpenCodec "Couldn't open codec %s, br=%d\n"
>>-#define MSGTR_FramesizeBufsizeTag "FRAME_SIZE: %d, BUFFER_SIZE: %d, TAG: 0x%x\n"
> 
> Ideally, if you remove a message, you should remove it from all
> translations as well to avoid cruft from piling up.

...true, but I hadn't realized this had been added to other translations
yet. In the event that I ever need to remove a message again, I'll try
to remember to check.

Do these two objections (and the two MSGTRs mentioned above) warrant my
correcting and re-sending the patch, or would you prefer to make the
tweaks on your end before applying?

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.